core: the default rate-limit store is per-process, so the limit multiplies by instance count
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- redis, typescript
- Domain
- authentication, backend, security
Research direction
Start by locating InMemoryRateLimitStore, RateLimitStoreInterface, and the auth package's rate-limit configuration. Compare the current per-process behavior with the requirements for a shared Redis-backed store and review where production boot warnings and configuration documentation belong. Done means multi-instance deployments have a supported shared-store option, the single-instance constraint is documented, and the production warning behavior is covered.
Written by the indexing model from the issue text.
Description
What happens
InMemoryRateLimitStore keeps its windows in a Map local to the
process. The auth package's rate limits — the ones protecting login, OTP,
recovery and password change — are therefore per instance.
Two pods means twice the configured attempts; behind an autoscaler the
limit is decorative for credential stuffing, and nothing in the
configuration or the logs indicates that the deployment shape changed the
security property.
The keying itself is careful (per route, IP and account combined), so
this is purely the store.
Proposal
- Document the constraint where the limits are configured: the in-memory
store is correct only for a single instance. - Ship a shared-store implementation of
RateLimitStoreInterface(Redis
is the common case) so a multi-instance deployment has a supported
option rather than a custom one. - Consider warning at boot when the in-memory store is active and
NODE_ENV === 'production'.
Related: #113 (a @RateLimit with no guard reaching the route).
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from btwld/rockets
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
question
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
question
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 92/100
lingdojo/kana-dojo#34449 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
drizzle-team/drizzle-orm#6726 ·
Maintainers usually reply within 2 days
-
bug platform-desktop platform-windows
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Termix-SSH/Termix#1951 · 2 comments ·
Maintainers usually reply within 1 day
-
Grok provider voice list shows 5 of xAI's 28 built-in voicesPossibly taken @hkjarral claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
hkjarral/AVA-AI-Voice-Agent-for-Asterisk#883 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100