build_registry rewrites the brand inside adjacent-literal prose

Open
#528 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
dart
Domain
build-system

Research direction

Start at tool/build_registry.dart:2479, where the ID check inspects only the first interpolated literal of an adjacent-string expression. Read the surrounding registry-generation logic to see how 'FortalInspired$group' ' for you' gets flattened before the brand substitution runs, then extend the check to cover the following prose literal. Run the generator against a fixture containing that adjacent-literal form; done means it keeps FortalInspired while still rewriting genuine Acme brands, with no change to #516's scope.

Written by the indexing model from the issue text.

Description

'FortalInspired$group' ' for you' is rendered as AcmeInspired.... The ID check looks only at the first interpolated literal and ignores the prose literal that follows it.

  • Location: tool/build_registry.dart:2479.
  • Main has this bug. It was found during the review of #516 and is outside that PR's scope.
Dominant language
Dart
Stars
24
Forks
5
Avg merge
15h 29m
Merged PRs (30d)
144

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from btwld/remix

All issues in btwld/remix

Similar issues

More Dart issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.