Broken build when requiring moment-timezone and moment
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, nodejs
- Domain
- build-system
Research direction
Start with the reproduction at https://github.com/davidlanger/factor-bundle-moment-timezone and install moment-timezone before moment, then compare the resulting bundle with the reverse installation order. Trace whether the duplicate moment dependency breaks factor-bundle or the package layout, and consider the issue done when the reproduction produces a working bundle consistently.
Written by the indexing model from the issue text.
Description
factor-bundle creates broken bundles when required modules have linked dependencies. This happens for example when installing moment-timezone and afterwards moment. So moment exists two times in the node_modules folder, once for moment-timezone and once in moment. This seems to break browserify. When installing the modules the other way around the bundle does not break (this time there is only one moment).
I don't know if this is more of a problem with the way npm install modules when they have duplicate dependencies or if this is a problem with factor bundle.
I set up a test case over at: https://github.com/davidlanger/factor-bundle-moment-timezone
- Dominant language
- JavaScript
- Stars
- 397
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from browserify/factor-bundle
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
browserify/factor-bundle#95 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
browserify/factor-bundle#94 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
browserify/factor-bundle#92 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
browserify/factor-bundle#83 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
browserify/factor-bundle#82 · 3 reactions ·
All issues in browserify/factor-bundle
Similar issues
-
bot:ai-assisted component:compact-js status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
midnightntwrk/midnight-sdk#403 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
DavidAnson/markdownlint-cli2#940 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#3692 ·
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 2/5 1-3 hours Newbie friendliness 90/100