borglab/gtsfm

Handling images without EXIF data

Open

#265 opened on Sep 5, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Jupyter Notebook (62 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (517 stars)
PR merge metrics
 (PR metrics pending)

Description

I guess I could have it require that ground truth intrinsics are provided.

Is the case for the intrinsics being None is handled anywhere? The output of get_intrinsics_from_exif() is Optional[Cal3Bundler], but it seems the ground truth intrinsics (or a good estimate) are required.

Originally posted by @travisdriver in https://github.com/borglab/gtsfm/pull/258#discussion_r702190601

Contributor guide

Research direction
Examine the get intrinsics from exif function and its callers to determine where the None case should be handled.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70