borglab/gtsfm

Interface between loaders and `GtsfmData`

Open

#263 opened on Sep 5, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Jupyter Notebook (62 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (517 stars)
PR merge metrics
 (PR metrics pending)

Description

this seems like this is a more general purpose function that should go into GtsfmData or something, like

class GtsfmData:
     @classmethod
     def from_colmap_model(cls, colmap_model_dir: str) -> "GtsfmData":

would that make sense?

Originally posted by @johnwlambert in https://github.com/borglab/gtsfm/pull/258#discussion_r701511870

Contributor guide

Research direction
Create a classmethod `from colmap model` in `GtsfmData` that wraps the existing loader logic, then replace calls to the standalone loader function with this method.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGTSAM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50