Potential for bad refs from import

Open
#2,594 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Read the linked discussion in pull request #2449 to find the import path and its diff_id validation steps. Trace when the ref is linked into the repo and how retries handle it; done means an unvalidated ref cannot be reused after a crash or power loss. The issue names no files or tests, so locate the relevant code and coverage from that entry point.

Written by the indexing model from the issue text.

Description

xref https://github.com/bootc-dev/bootc/pull/2449#discussion_r4391329884

I think we can improve this so we don't link the ref into the repo until after diff_id validation. Otherwise if we have an untimely crash / power loss a retry of the operation is going to see the potentially bad ref and blindly try to use it.

Dominant language
Rust
Stars
2.3k
Forks
230
Avg merge
2d 11h
Merged PRs (30d)
42

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bootc-dev/bootc

All issues in bootc-dev/bootc

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.