Signed/unsigned conversion in Boost.Python
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 50/100
Research direction
Inspect boost/include/boost/python/suite/indexing/detail/indexing_suite_detail.hpp at lines 176 and 611, checking the types returned or modified by the referenced operations. Update the signed/unsigned handling without changing behavior, then build or run the relevant Boost.Python checks and confirm the compiler warnings are resolved.
Written by the indexing model from the issue text.
Description
Using Boost v1.90
In boost/include/boost/python/suite/indexing/detail/indexing_suite_detail.hpp there are locals that have a signed/unsigned mismatch.
On L176, a local variable index declared as long is assigned to a return that can be unsigned (size_t).
Similarly, on L611, another local variable from is declared as long then operator+= is used for a variable that has an unsigned type.
This results in an unnecessarily wordy warning in the compiler (in my case msvc 14.2)
- Dominant language
- C++
- Stars
- 537
- Forks
- 223
- Avg merge
- 11h 22m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/python
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
BoostDetectToolset-1.90.0.cmake file not found in an include() call in boost_python-config.cmake Open
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 88/100
QuantStack/git2cpp#187 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100