`no_proxy_helper` should not access `Container::value_type`

Open
#419 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
api

Research direction

Read include/boost/python/suite/indexing/detail/indexing_suite_detail.hpp around line 487, then trace how indexing_suite receives the element type through its Key or Data template parameters. Confirm that the implementation no longer requires Container::value_type, and verify that containers without a suitable value_type remain supported.

Written by the indexing model from the issue text.

Description

see code here

Some containers may not provide proper value_type member, and the user can still manually passing its element type as Key or Data template parameter to indexing_suite. So indexing_suite already know the container's value type, and does not need containers to have ::value_type. Its detailed implementation should then directly reading it from indexing_suite, not from Container::value_type again.

Dominant language
C++
Stars
537
Forks
223
Avg merge
11h 22m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from boostorg/python

All issues in boostorg/python

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.