shared_ptr_from_python.hpp shadow storage compiler warning
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Inspect the referenced change and include/boost/python/converter/shared_ptr_from_python.hpp lines 44-65, then reproduce the warning with the MSVS 2022 build context described in the issue. Confirm that the shadow-storage warning is no longer emitted and that the affected shared_ptr conversion still builds successfully.
Written by the indexing model from the issue text.
Description
Please check change to shared_ptr_from_python.hpp from https://github.com/boostorg/python/commit/aca3c80c4f80dd3d52219e1ee299e08bb980bcfd
C:\projects\pythonscript\packages\boost.1.80.0\lib\native\include\boost\python\converter\shared_ptr_from_python.hpp(52,1): warning C4456: declaration of 'storage' hides previous local declaration (compiling source file ..\src\NotepadPython.cpp) [C:\projects\pythonscript\PythonScript\project\PythonScript2010.vcxproj]
C:\projects\pythonscript\packages\boost.1.80.0\lib\native\include\boost\python\converter\shared_ptr_from_python.hpp(46,17): message : see declaration of 'storage' (compiling source file ..\src\NotepadPython.cpp) [C:\projects\pythonscript\PythonScript\project\PythonScript2010.vcxproj]
C:\projects\pythonscript\packages\boost.1.80.0\lib\native\include\boost\python\converter\shared_ptr_from_python.hpp(45): message : while compiling class template member function 'void boost::python::converter::shared_ptr_from_python<T,std::shared_ptr>::construct(PyObject *,boost::python::converter::rvalue_from_python_stage1_data *)' [C:\projects\pythonscript\PythonScript\project\PythonScript2010.vcxproj]
From https://ci.appveyor.com/project/bruderstein/pythonscript/builds/44940991/job/g43lxe0hqbj7lrhx build with MS VS2022.
Looks like a merge issue.
- Dominant language
- C++
- Stars
- 537
- Forks
- 223
- Avg merge
- 11h 22m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boostorg/python
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
BoostDetectToolset-1.90.0.cmake file not found in an include() call in boost_python-config.cmake Open
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100