preview.yml default globs ./packages/** and ./examples/** recurse into node_modules
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Start in preview.yml by inspecting the default publish and template globs and how they are passed to pkg-pr-new. Use the linked clink preview run as the reproduction, then verify that the publish step no longer walks nested node_modules or fails on nameless package.json files.
Written by the indexing model from the issue text.
Description
Problem
preview.yml defaults its inputs to recursive globs:
publish:
default: "./packages/**"
template:
default: "./examples/**"
and passes them to pkg-pr-new:
pnpx pkg-pr-new publish --pnpm "$PUBLISH_GLOB" --template "$TEMPLATE_GLOB"
The ** matches recursively, including into each package's node_modules. pkg-pr-new then walks nested dependency package.json files and aborts on any that lack a name field — which is common for internal stub manifests such as vite's:
[error] "name" field in .../packages/clink/node_modules/vite/types/package.json should be defined
##[error]Process completed with exit code 1.
(Preceded by many Skipping .../node_modules/.../*.ts: not a directory or .tgz/.tar.gz file lines as it scans the dependency tree.)
Impact
Any repo whose packages depend on something that ships a nameless nested package.json (vite is a frequent one). The preview job fails at the publish step even though install and build succeed. Latent until the build step actually completes and pkg-pr-new runs.
Repro
- Concrete instance: bombshell-dev/clink#43 — the
previewrun that reached the "Publish Preview" step:
https://github.com/bombshell-dev/clink/actions/runs/30575154965
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bombshell-dev/automation
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
bombshell-dev/automation#33 ·
All issues in bombshell-dev/automation
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr impact:session-state issue-rating: 🌊 off-meta tidepool P2
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openclaw/openclaw#165245 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
agent-canvas bug priority:low ready-for-dev
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
🐛 bug
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
spicetify/marketplace#1262 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 68/100
Maintainers usually reply within 1 day