`cargo fmt` would reformat almost every file
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 78/100
Research direction
Start by reading rustfmt.toml and run cargo fmt --all -- --check to see the formatting differences. Set the formatter width to match the 120-character code style, then rerun the check; done when it passes or any remaining formatting differences are identified and fixed.
Written by the indexing model from the issue text.
Description
The code is written up to 120 characters wide, but rustfmt.toml doesn't set max_width, so cargo fmt uses 100 and wants to change nearly every file:
$ cargo fmt --all -- --check
Diff in crates/bolt-language-server/src/db.rs:16:
- let db = Self { storage: salsa::Storage::new(None), files: Files::new(), system: LspSystem::new(disk) };
+ let db = Self {
+ storage: salsa::Storage::new(None),
+ files: Files::new(),
+ system: LspSystem::new(disk),
+ };
...
So cargo fmt can't be used to check new code. Adding max_width = 120 to rustfmt.toml probably fixes most of it; whatever is left can be formatted once.
- Dominant language
- Rust
- Stars
- 54
- Forks
- 3
- Avg merge
- 7m
- Merged PRs (30d)
- 28
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from boltlang/Bolt
-
discussion documentation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug scope:types
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug scope:types
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement scope:diagnostics scope:syntax
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
bug scope:types
Difficulty 4/5 1-2 days Newbie friendliness 52/100
Maintainers usually reply within 1 day
Similar issues
-
bug dependencies kind:fix priority: P3 ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
shep-pm/shep#1318 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
swc-project/swc-next#1165 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Alive24/shea-symphony#574 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day