The radio playlist are limited to 200 tracks

Open Beginner friendly
  • Is something wrong?
#681 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
api, cli

Research direction

The cap is the countryTrackLimit constant of 200 in external/radios/countries.go, around line 22, which the reporter identifies as the cause. Read that file and find where the constant is used to see how the station list is fetched and truncated. Before changing it, check the code comment explaining the limit, since the maintainer may want a higher cap or pagination rather than removal. Done means the country's full station list is shown, or the limit is raised with a clear reason, and the radio panel still navigates smoothly.

Written by the indexing model from the issue text.

Description

bug

What happened

Using cliamp to browse radio streaming station per countries allow to browse only 200 items althought there are much more

Steps to reproduce

  1. ./cliamp
  2. Ctrl + R to refresh the radio stations
  3. Shift + R to go on the radio panel
  4. Browse all countries
  5. Select United States of America
  6. Select By Name

Expected behavior

All the existing radio for this country should be displayed, but we've got only 200

Screenshots / video

Environment

  • cliamp version (cliamp --version): v2.3.0-713-g02309c90-dirty
  • OS: Mac Os
  • Audio backend (PipeWire / PulseAudio / ALSA):
  • Provider(s) involved: Rqdio

In fact I've found the cause in the code. On external/radios/countries.go L22 there is a countryTrackLimit of 200 (or to the the cap much higher). Could we get rid of it in order to display all of the available radios for a country? In contrary of the comments in the code some people would like to browse the complete playlist of a country to see all of the existing web radios easyly. I will do a pull request for that or perhaps you've got another idea about to make my PR less dirty or you don t want to go over 200 displayed radios at the same time :)

Dominant language
Go
Stars
4.4k
Forks
307
Avg merge
4d 18h
Merged PRs (30d)
13

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bjarneo/cliamp

All issues in bjarneo/cliamp

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.