Text that bit new generates has a renamed "bit Boilerplate" and stray indentation

Open Beginner friendly
  • Is something wrong?
#15,109 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, xml
Domain
cli

Research direction

Run bit new to generate a project named MyApp, then open Boilerplate.Server.Api/Features/Identity/OAuth/Services/OAuthProtectedResource.cs and Boilerplate.Server.Api/Boilerplate.Server.Api.csproj. The payload does not name the template-processing code that does the source name replacement and marker removal, so find that first. Done means the comment no longer reads "a bit MyApp app", and the removed msbuild-conditional markers leave no stray indentation or leftover 4-space line in the csproj.

Written by the indexing model from the issue text.

Description

area / templates

Two cosmetic slips in what bit new 11.0.0-pre-20 generates, both from how the template's text is processed:

  • Boilerplate.Server.Api/Features/Identity/OAuth/Services/OAuthProtectedResource.cs has a comment saying "a bit Boilerplate app". The source name replacement turns it into "a bit MyApp app" in a project named MyApp. Wording that doesn't contain "Boilerplate", such as "an app made from bit-bp", stays right.
  • Boilerplate.Server.Api/Boilerplate.Server.Api.csproj: the <!--/-:msbuild-conditional:noEmit --> and <!--/+:msbuild-conditional:noEmit --> markers are removed but their indentation stays. So the <!-- The template version bit.json records ... --> comment comes out indented by 8 spaces instead of 4, and a line of only 4 spaces follows the BitTemplateVersion ItemGroup.
Dominant language
C#
Stars
1.4k
Forks
264
Avg merge
8h 58m
Merged PRs (30d)
579

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bitfoundation/bitplatform

All issues in bitfoundation/bitplatform

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.