Firequery spams warnings in console

Open
#11 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Start at the check on line 136 in the WebDeveloper plugin code and reproduce the console warnings on a page without jQuery. Verify the changed check still detects jQuery when it is present and produces no "window.jQuery is undefined" warnings when it is absent.

Written by the indexing model from the issue text.

Description

investigate

Firequery spams messages to the console of the webdeveloper plugin, when a page doesn't use jQuery (Click on right icon in the WebDeveloper Toolbar).

It's the check in Line 136:
if (window.jQuery) {

That results in many "Warning: window.jQuery is undefined" messages...
Better use a typeof check :)

Dominant language
JavaScript
Stars
170
Forks
18
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from binaryage/firequery

All issues in binaryage/firequery

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.