data events not displaying with jquery 1.9.1 ++

Open
#34 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript, jquery
Domain
devtools

Research direction

Start in firequery.js around line 630 and compare the provided jQuery 1.8.3 and 1.9.1 jsFiddle cases. Check how event data is accessed across those jQuery versions, including the suggested jQuery._data(element, "events") path. Done means data events display with jQuery 1.9.1 and later without breaking the 1.8.3 case.

Written by the indexing model from the issue text.

Description

Hi there!

I saw the issue https://github.com/binaryage/firequery/issues/33 has been closed and indeed events are shown with this version.

It still works with jquery 1.8.3:
http://jsfiddle.net/FRZwp/2/

However with jquery 1.9.1 and onwards it doesn't work anymore:
http://jsfiddle.net/FRZwp/1/

Maybe the firequery code (firequery.js, starting from line 630) should implement the jQuery._data(element, "events") in some way?

cheers

Dominant language
JavaScript
Stars
170
Forks
18
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from binaryage/firequery

All issues in binaryage/firequery

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.