BEMAN_USE_MODULES should probably default to OFF
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- cpp
- Domain
- build-system
Research direction
Start by locating where BEMAN_USE_MODULES is defined and where module support detection sets its default. Change the default behavior so modules are OFF unless explicitly enabled, then verify configuration and consumer target-linking behavior in the relevant build setup.
Written by the indexing model from the issue text.
Description
Currently, BEMAN_USE_MODULES is automatically set to ON when module support is detected. This is usually not what I would want, and I suspect is not what other users would want, as module support is still unreliable (and in this case, doesn't buy much.)
It would probably be better if BEMAN_USE_MODULES unconditionally defaults to OFF, making module support opt-in.
This issue is made more pressing by https://github.com/bemanproject/execution/issues/246, because currently consumers need to care about BEMAN_USE_MODULES in order to know to what target to link.
- Dominant language
- C++
- Stars
- 150
- Forks
- 23
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bemanproject/execution
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
bemanproject/execution#246 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bemanproject/execution#245 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
bemanproject/execution#252 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
bemanproject/execution#248 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
bemanproject/execution#207 · 7 comments ·
All issues in bemanproject/execution
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
google/libultrahdr#485 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
godotengine/godot#123776 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 60/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ros2/common_interfaces#344 ·