Thread architecture still depends on replyToEventId/rootEventId
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reading NoteRelationModel and tracing the thread-loading, reply-discovery, parent/root resolution, and reply-visibility paths that currently use replyToEventId or rootEventId. The issue does not identify files or tests, so first locate those entry points and inspect the regressions found during testing. Done would require a defined migration that preserves those behaviors, but the scope and acceptance criteria are not specified.
Written by the indexing model from the issue text.
Description
Summary
While investigating a migration toward using NoteRelationModel as the single source of truth for thread relationships, I found that the current thread architecture still depends on replyToEventId and rootEventId in several places.
Findings
- NoteRelationModel currently stores untyped relation edges.
- Root edges are excluded.
- The relation graph does not contain enough information to fully reconstruct thread structure.
- Removing or bypassing replyToEventId/rootEventId causes regressions in:
- Thread loading
- Reply discovery
- Parent/root note resolution
- Reply visibility
Notes
During testing, relying only on NoteRelationModel caused thread-related regressions, suggesting that a complete migration would likely require broader changes to the relation layer.
This does not affect the fix in PR #102, but was discovered while investigating the underlying architecture.
- Dominant language
- Dart
- Stars
- 2
- Forks
- 2
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 35
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from basictech01/uniun
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
basictech01/uniun#300 ·
Maintainers usually reply within 1 day
-
enhancement good first issue P2-Medium
Difficulty 5/5 Over a week Newbie friendliness 25/100
basictech01/uniun#296 ·
Maintainers usually reply within 1 day
-
bug good first issue P2-Medium
Difficulty 4/5 1-2 days Newbie friendliness 22/100
basictech01/uniun#293 ·
Maintainers usually reply within 1 day
-
bug P1-High
Difficulty 4/5 3-5 days Newbie friendliness 18/100
basictech01/uniun#286 · 2 comments ·
Maintainers usually reply within 1 day
-
P3-Low
Difficulty 4/5 1-2 days Newbie friendliness 30/100
basictech01/uniun#282 · 1 comment ·
Maintainers usually reply within 1 day
All issues in basictech01/uniun
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 65/100
chriskelly/wish-together#36 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AppFlowy-IO/AppFlowy#9075 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Paste asks for iOS paste permission because the default context menu ignores SystemContextMenuPossibly taken @dorklein claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
maheshj01/searchfield#267 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
jhomlala/betterplayer#1616 ·
Maintainers usually reply within 1 day