loadMintIgnore mis-parses directory patterns without a leading slash
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript
- Domain
- documentation
Research direction
Start in scripts/lib/docs-utils.js at loadMintIgnore(), especially the directory-pattern branch that handles paths ending in /. Check that both /foo/ and foo/* preserve the same directory name, then verify that a slashless pattern such as draft-notes/* is ignored without a warning.
Written by the indexing model from the issue text.
Description
loadMintIgnore() handles directory patterns ending in /*, but it always removes the first character with slice(1, -2).
File evidence:
scripts/lib/docs-utils.jschecksif (trimmed.endsWith('/*')).- That branch stores
ignored.dirs.add(trimmed.slice(1, -2)), assuming the pattern starts with/. - The file-pattern branch immediately below supports both leading-slash and bare filenames, so a contributor can reasonably expect
foo/*to work the same way as/foo/*.
For a slashless directory pattern such as draft-notes/*, the parser stores raft-notes, so the intended directory is not ignored and there is no warning.
Expected behavior: directory patterns should preserve the directory name whether they are written as /foo/* or foo/*.
- Dominant language
- JavaScript
- Stars
- 337
- Forks
- 798
- Avg merge
- 13h 7m
- Merged PRs (30d)
- 57
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from base/docs
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100
-
Issue-Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sugarlabs/musicblocks#8924 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ArduPilot/ardupilot_wiki#8088 ·
-
[BUG] createTool tools cannot be registered with Mastra when exactOptionalPropertyTypes is enabled Opencustomer-eng status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100