ballerina:2 reports methods of an object constructor that initializes a typed class field

Open
#201 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@TharmiganK is already working on this.

Since Nov 13, 2026.

  • #204 by @TharmiganK — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
22/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
java
Domain
devtools

Research direction

Start with StaticCodeAnalyzer.contextualTypes, which has no case for ObjectFieldNode and falls back to semanticModel.expectedType. Run bal scan field.bal on the reproduction in the issue to confirm that line 7 is reported and line 12 is not. Done means the class-field object constructor is no longer flagged while the existing rule tests still pass. Pull request #204 is already open against this issue, so check it before starting.

Written by the indexing model from the issue text.

Description

Area/Rules Type/Bug
Area

Rules

Description

ballerina:2 should not report the parameters of methods that implement a method of the type of an object constructor (#169, #173 and the 0.11.x backport #182). When the object constructor initializes a typed class field, the parameter is still reported. The same constructor, typed by the same object type, is not reported as a module variable, local variable, return value, argument, assignment, record field or expression body. An anonymous function in a class field initializer (final BinOp f = function(int a, int b) ...) is not reported either.

Likely cause, from reading the source (not verified): StaticCodeAnalyzer.contextualTypes has no case for ObjectFieldNode and falls back to semanticModel.expectedType(document, startLine), which does not give the field's type for an object constructor.

Found while testing v0.14.0 (#186) and v0.11.2 (#187).

Steps to Reproduce

field.bal:

type Op object {
    function m(int p) returns int;
};

class Holder {
    final Op viaField = object {
        function m(int p) returns int => 1;
    };
}

Op viaModule = object {
    function m(int p) returns int => 1;
};

public function main() {
    _ = new Holder();
    _ = viaModule;
}

Run bal scan field.bal.

Expected Behavior

No issues: both m methods implement Op.m, so their signatures are fixed by the type.

Actual Output
[('ballerina:2', 7)]

Line 7 (the class field) is reported; line 12 (the module variable) is not.

Ballerina Version

2201.12.0 (scan 0.11.2); 2201.13.2 and 2201.14.1 (scan 0.14.0)

Scan Tool Version

0.14.0 and 0.11.2 (DEV Central)

Environment

macOS

Dominant language
Java
Stars
15
Forks
12
Avg merge
2d 8h
Merged PRs (30d)
29

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ballerina-platform/static-code-analysis-tool

All issues in ballerina-platform/static-code-analysis-tool

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.