Add note / ADR about why :shutdown isn't set by default

Open
#30 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
clojure
Domain
documentation

Research direction

Add a note or ADR explaining why :shutdown is not set by default. Use the issue's stated risk that the shutdown-hook closure is retained until shutdown and can create uncollected garbage across many processes. The work is done when this rationale is recorded in the project documentation.

Written by the indexing model from the issue text.

Description

The reason for this is that adding a shutdown hook by default creates a potential memory leak problem: the closure will be retained until shutdown. In case of lots of processes, this will create lots of uncollected garbage.

Dominant language
Clojure
Stars
251
Forks
35
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from babashka/process

All issues in babashka/process

Similar issues

More Clojure issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.