Async generator entrypoint keeps running after the client disconnects (follow-up to #482)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in the runtime app module where the entrypoint branches to StreamingResponse(self._sync_stream_with_error_handling(result), media_type="text/event-stream"), and read _async_gen_to_sync_gen and its finally to see why it never runs. Reproduce with the 12-step async generator and disconnecting client given here, then wrap the sync stream in an async iterator that closes both the stream and the source generator in finally. Add test_handler_is_closed_after_disconnect to tests/integration/runtime/test_streaming_disconnect_integration.py and run it plus test_app.py; done means the handler logs CancelledError around the next yield after disconnect rather than running to completion.
Written by the indexing model from the issue text.
Description
Describe the bug
When an async def generator entrypoint is streamed and the client disconnects, the handler is never closed. It keeps running to the end, and if more than 100 events remain, the producer task stays parked in _offer() forever (polling every 10 ms) for the life of the process.
#563 added cleanup for this in the finally of _async_gen_to_sync_gen (stop.set() + task.cancel()), but that finally never runs. Starlette's iterate_in_threadpool never calls close() on the sync generator it iterates, so no GeneratorExit reaches it. The unit test for #563 calls sync_gen.close() by hand (test_app.py, _abandon_after), and the integration test only checks that /ping and a fresh session still work, so this was not caught.
To Reproduce
bedrock-agentcore 1.27.0 (main @ 8467c9a), starlette 1.10.0, uvicorn 0.54.0, Python 3.12, macOS.
# server.py
import asyncio, time
from bedrock_agentcore.runtime import BedrockAgentCoreApp
app = BedrockAgentCoreApp()
@app.entrypoint
async def invoke(payload):
try:
for i in range(12):
await asyncio.sleep(1)
print(f"{time.time():.1f} step {i + 1}/12", flush=True)
yield {"step": i + 1}
print("finished all steps", flush=True)
except BaseException as e:
print(f"{time.time():.1f} closed: {type(e).__name__}", flush=True)
raise
app.run(port=8080)
# client.py: read for 3 seconds, then disconnect
import time, httpx
start = time.time()
with httpx.Client(timeout=30) as c, c.stream("POST", "http://127.0.0.1:8080/invocations", json={}) as r:
for _ in r.iter_raw():
if time.time() - start >= 3:
break
print(f"{time.time():.1f} client disconnected")
The client disconnects after step 3. The server prints steps 4 to 12 and then finished all steps.
With range(500) and asyncio.sleep(0.01), the server stops around step 103/500 and never prints anything again. That is 100 queued events plus a few in flight, with the producer parked in _offer().
Expected behavior
The handler is closed shortly after the disconnect, as the _async_gen_to_sync_gen docstring describes.
Possible fix
Iterate the sync generator ourselves and close it in finally:
- return StreamingResponse(self._sync_stream_with_error_handling(result), media_type="text/event-stream")
+ return StreamingResponse(self._iterate_sync_stream(result), media_type="text/event-stream")
...
+ async def _iterate_sync_stream(self, generator):
+ stream = self._sync_stream_with_error_handling(generator)
+ try:
+ async for chunk in iterate_in_threadpool(stream):
+ yield chunk
+ finally:
+ stream.close()
+ generator.close()
With this change, the repro above logs closed: CancelledError at step 4, and the 500-step case stops at step 2. I added an integration test, test_handler_is_closed_after_disconnect, to test_streaming_disconnect_integration.py. It fails on main and passes with the change (5/5 runs). test_app.py passes (148).
Integration test (added to tests/integration/runtime/test_streaming_disconnect_integration.py)
The live_server handler records how it exits ("completed" or "closed") per sessionId in a module-level _handler_exits dict, cleared by the fixture.
def test_handler_is_closed_after_disconnect(live_server):
"""A mid-stream client disconnect closes the handler instead of leaving its producer parked."""
base = live_server
with httpx.Client(timeout=30.0) as c:
with c.stream("POST", f"{base}/invocations", json={"sessionId": "A", "chunks": 5000}) as r:
for i, _ in enumerate(r.iter_lines()):
if i >= 3:
break
deadline = time.time() + 5
while "A" not in _handler_exits and time.time() < deadline:
time.sleep(0.1)
assert _handler_exits.get("A") == "closed"
Notes
- Cleanup can be delayed. uvicorn reports ASGI spec 2.3, so Starlette cancels the response through a task group. That cancel waits for the in-flight
next()in the thread pool, so cleanup happens when the handler yields its next event. A handler parked in a long call is closed only after that call returns. - Sync generator handlers change too. They go through the same path, so they also get closed on disconnect now.
- Scope. I only checked this locally with uvicorn, not on AgentCore Runtime.
- Dominant language
- Python
- Stars
- 786
- Forks
- 163
- Avg merge
- 4h
- Merged PRs (30d)
- 22
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws/bedrock-agentcore-sdk-python
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aws/bedrock-agentcore-sdk-python#751 · 1 reaction ·
Maintainers usually reply within 1 day
-
delete_all_long_term_memories_in_namespace deletes only the first 10 recordsPossibly taken @Fire162 claimed this 18 days ago. Openbug high-severity
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
aws/bedrock-agentcore-sdk-python#727 ·
Maintainers usually reply within 1 day
-
MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challengePossibly taken @abhiramshaji-cyber claimed this 24 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aws/bedrock-agentcore-sdk-python#702 ·
Maintainers usually reply within 1 day
-
[Bug] update_message fails with parameter validation error when SessionMessage.message_id is a Strands positional integer indexPossibly taken @citizen204 claimed this 144 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aws/bedrock-agentcore-sdk-python#556 ·
Maintainers usually reply within 1 day
-
CodeInterpreter should not require a region argumentPossibly taken @citizen204 claimed this 159 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aws/bedrock-agentcore-sdk-python#511 ·
Maintainers usually reply within 1 day
All issues in aws/bedrock-agentcore-sdk-python
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
snap-stanford/Biomni#380 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/playwright-python#3361 ·
Maintainers usually reply within 1 day
-
documentation priority: low size: S status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
cubrid-lab/sqlalchemy-cubrid#1397 ·
Maintainers usually reply within 1 day
-
documentation priority: low size: S status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cubrid-lab/pycubrid#1307 ·
Maintainers usually reply within 1 day
-
[Bug]: Installer hides SSL certificate errors as bare URLError, and the suggested fix can't workOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ShaftHQ/chaosengine-harness#143 ·
Maintainers usually reply within 1 day