FR: Support for Spring WebClient
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the Spring WebClient call shown in the issue and inspect the agent's existing HTTP client instrumentation entry points; no repository file or test is named. Done means a downstream WebClient request carries the X-Ray trace header, with the behavior covered by an appropriate test.
Written by the indexing model from the issue text.
Description
FR: Support for Spring WebClient
In my sample application using Spring WebClient with X-Ray Java agent auto-instrumentation, the trace header is not injected into the http header.
This is the code block for the downstream http call using Spring webclient
import org.springframework.web.reactive.function.client.WebClient;
import org.springframework.web.bind.annotation.RequestHeader;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;
@RestController
@RequiredArgsConstructor
@Slf4j
public class GoodbyeController {
private final WebClient additionWebClient;
@GetMapping("/goodbye")
public ResponseEntity<?> goodbye() throws InterruptedException {
MathResult addResult =
this.additionWebClient
.get()
.uri(
uri ->
uri.path("/add")
.queryParam("x", Long.toString(x))
.queryParam("y", Long.toString(y))
.build())
.retrieve()
.bodyToMono(MathResult.class)
.block();
}
}
In the downstream http request handler, I printed out the request header and found that no trace id,
2021-03-04 16:19:18.841 INFO [Addition App,604108865e2cf420e5d967d9c6dc0ec3,e5d967d9c6dc0ec3,true] 25 --- [nio-8080-exec-8] c.g.t.s.tracingpoc.AdditionController : Starting to add... x: [100], y: [1000]. RequestHeaders: [{accept-encoding=gzip, user-agent=ReactorNetty/0.9.8.RELEASE, host=<redacted>:8080, accept=*/*}]
- Dominant language
- Java
- Stars
- 46
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws/aws-xray-java-agent
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
aws/aws-xray-java-agent#120 · 2 comments ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
aws/aws-xray-java-agent#118 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
aws/aws-xray-java-agent#117 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
aws/aws-xray-java-agent#111 · 1 comment ·
-
Using xray-agent 3.3.3 in AML2 on tomcat serverMay be free again @willarmiros claimed this 1832 days ago, and no pull request is open. Openquestion stale
aws/aws-xray-java-agent#108 · 2 comments · 1 assignee ·
All issues in aws/aws-xray-java-agent
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
objectionary/eo#9182 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
objectionary/hone-maven-plugin#1293 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MaikuB/flutter_appauth#683 ·
-
wait for review
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day