Missing field enableSMSMFA on struct events.CognitoEventUserPoolsMigrateUserResponse

Open
#553 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
go
Domain
backend

Research direction

Start by reading events/cognito.go and the linked Amazon Cognito user migration event documentation, then inspect CognitoEventUserPoolsMigrateUserResponse. Done means the response struct exposes enableSMSMFA with the documented JSON name, matching the requested field and allowing it to be unmarshaled.

Written by the indexing model from the issue text.

Description

enhancement type/events

Is your feature request related to a problem? Please describe.
According to cognito migrate user lambda trigger documentation the event struct could use a field called enableSMSMFA to allow force the migrated user to trigger the SMSMFA step.

That field is not present in the current events package.

Describe the solution you'd like
On file events/cognito.go:

// CognitoEventUserPoolsMigrateUserResponse contains the response portion of a MigrateUser event
type CognitoEventUserPoolsMigrateUserResponse struct {
	UserAttributes         map[string]string `json:"userAttributes"`
	FinalUserStatus        string            `json:"finalUserStatus"`
	MessageAction          string            `json:"messageAction"`
	DesiredDeliveryMediums []string          `json:"desiredDeliveryMediums"`
	ForceAliasCreation     bool              `json:"forceAliasCreation"`
	EnableSMSMFA           bool              `json:"enableSMSMFA"`
}

Describe alternatives you've considered
For now I'm trying to create a local struct that inlude the original plus that field:

type	UserMigrationEventResponse struct {
	events.CognitoEventUserPoolsMigrateUserResponse
	EnableSMSMFA bool `json:"enableSMSMFA"`
}

type UserMigrateAuthEvent struct {
	events.CognitoEventUserPoolsHeader
	events.CognitoEventUserPoolsMigrateUserRequest `json:"request"`
	UserMigrationEventResponse                     `json:"response"`
}

Additional context
Documentation of the event: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-migrate-user.html#cognito-user-pools-lambda-trigger-syntax-user-migration

Dominant language
Go
Stars
3.8k
Forks
578
Avg merge
16h 56m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws/aws-lambda-go

All issues in aws/aws-lambda-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.