lambdaurl Wrap is not proxying `LambdaFunctionURLRequest.Cookies`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Start with Wrap in lambdaurl/http_handler.go around line 105 and compare its request construction with the referenced requestv2.go behavior. Done when cookies from LambdaFunctionURLRequest are represented in the resulting http.Request headers and the repository's Go tests pass.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
The Wrap function from https://github.com/aws/aws-lambda-go/blob/main/lambdaurl/http_handler.go#L105 creates an http.Request from an events.LambdaFunctionURLRequest. I don't see any references to proxying the original request's cookies similar to what aws-lambda-go-api-proxy does:
for _, cookie := range req.Cookies {
httpRequest.Header.Add("Cookie", cookie)
}
This is a deal-breaker for me because my stream handlers rely on cookies
Describe the solution you'd like
Copy and paste that code block (I'll do this with a PR after creating this issue).
Describe alternatives you've considered
I don't think this module would like to take a dependency on aws-lambda-go-api-proxy so copying and pasting may be best.
Additional context
None.
- Dominant language
- Go
- Stars
- 3.8k
- Forks
- 578
- Avg merge
- 16h 56m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws/aws-lambda-go
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
aws/aws-lambda-go#634 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
aws/aws-lambda-go#556 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
aws/aws-lambda-go#610 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
aws/aws-lambda-go#598 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
aws/aws-lambda-go#592 ·
All issues in aws/aws-lambda-go
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·