bug: cfn.LambdaWrap doesn't fail correctly when custom resources error out
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with the cfn.LambdaWrap entry point and reproduce the issue using the lambda.Start and boom example from the report. Trace the custom resource error path and verify that returning errors.New("BOOM") makes CloudFormation fail resource creation and roll back instead of succeeding.
Written by the indexing model from the issue text.
Description
Hi,
When creating lambda functions that respond to CFN Custom Resources, the cfn.LambdaWrap function does not make the resource creation fail as it should when returning an error.
Example:
func main() {
lambda.Start(cfn.LambdaWrap(boom))
}
func boom(ctx context.Context, event cfn.Event) (physicalResourceID string, data map[string]interface{}, err error) {
return "", nil, errors.New("BOOM")
}
Expected result:
The custom cloudformation resource creation fails, and rolls back.
Actual result:
Resource creation succeeds.
- Dominant language
- Go
- Stars
- 3.8k
- Forks
- 578
- Avg merge
- 16h 56m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws/aws-lambda-go
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
aws/aws-lambda-go#634 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
aws/aws-lambda-go#597 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
aws/aws-lambda-go#556 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
aws/aws-lambda-go#610 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
aws/aws-lambda-go#598 ·
All issues in aws/aws-lambda-go
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·