Increase resilience and simplify the implementation
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start by reading package.json and app.js to understand the current start command and clustering logic. Compare the requested PM2 setup with the existing process behavior, then verify that npm start launches the sample as specified and that clustering is no longer handled in app.js.
Written by the indexing model from the issue text.
Description
I have a suggestion to improve the resilience and align a bit more with industry standards.
You should not be doing clustering in your code. I adds noise and is right now preventing the script from running unclustered. There are pretty sweet tools to manage your process, bring it back up when it crashes, monitor it and finally cluster it. Tools like PM2
What I suggest is to:
- add the
pm2dependency to thepackage.json - remove the clustering logic from
app.js - change the
npm startcommand forpm2 start app.js -i maxwheremaxcan easily be changed to any number to define the number of clusters to make.
PM2 also has the advantage to be hookable for remote monitoring with almost no effort, which could be interesting for this project.
Cheers
- Dominant language
- EJS
- Stars
- 279
- Forks
- 247
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws-samples/eb-node-express-sample
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
aws-samples/eb-node-express-sample#29 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aws-samples/eb-node-express-sample#25 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
aws-samples/eb-node-express-sample#23 · 2 comments · 5 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aws-samples/eb-node-express-sample#20 · 2 comments ·
All issues in aws-samples/eb-node-express-sample
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
speaches-ai/speaches#678 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
[BUG] ECR GetAuthorizationToken returns a proxyEndpoint for the default region, not the request's Openbug ecr
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conda-forge/spacy-feedstock#177 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100