Rebroadcast Bug
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- go
- Domain
- distributed-systems
Research direction
No file, test, or entry point is named in the issue. Reproduce the b1/b2/b3 notarization and finalize-vote scenario described here, then clarify the intended safety invariant with maintainers; done means the unsafe or duplicate finalization cannot be produced.
Written by the indexing model from the issue text.
Description
Our current flow of rebroadcasting finalize votes could cause a safety failure.
Say we finalize b3 which belongs to this chain of blocks. b1 <- b3(we have not yet finalized b1. However, our node has a notarization for b2. In our current logic, we would create a finalize vote for b2 and broadcast it. In fact a quorum of nodes had b2 notarized, but the block proposer build off the empty notarization in b2. We could end up creating a finalization for b2 which would be the same sequence as b3.
- Dominant language
- Go
- Stars
- 22
- Forks
- 4
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 16
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ava-labs/Simplex
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 40/100
Maintainers usually reply within 1 day
-
Verification accepts aux info appends after the history is sufficient, changing the approval digestOpen
Difficulty 3/5 1-2 days Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in ava-labs/Simplex
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
limitlessprojects/Go-Hybrid#50 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
vinyldns/go-vinyldns#106 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
praetorian-inc/augustus#334 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/clickhouse-go#2066 ·
Maintainers usually reply within 1 day