Every property is optional ConnectionForList, even id and name

Open
#1,106 3 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript

Research direction

Start by comparing the ConnectionForList type with Connection and reviewing change #1093, which introduced the optional properties in v4.22.0. Confirm the intended required fields, especially id and name, and check the API documentation for the list response; the issue is done when the rationale or corrected type requirements are established.

Written by the indexing model from the issue text.

Description

bug vNext
Checklist
  • I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.
Description

#1093 changed the type from Connection to ConnectionForList but in the process made every property optional, which seems like a rather odd choice considering at least id and name are mandatory.

As asked by @cwkfs, why was this change made?

Reproduction
  1. Upgrade to v4.22.0
Additional context

No response

node-auth0 version

4.22.0

Node.js version

20

Dominant language
TypeScript
Stars
683
Forks
319
Avg merge
1d 30m
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from auth0/node-auth0

All issues in auth0/node-auth0

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.