Follow-up fixes for pregate attestation (post-merge review of #12299)
Maintainers usually reply within 1 day
Assessment
This issue has not been assessed yet.
Description
PR #12299 merged before a final Codex review pass completed; the pass returned these findings against the merged diff (not yet independently reproduced, verify first).
.github/workflows/ci.yml("Install autofixer dependencies", ~line 217): the install runs in the impact job, but server shards use separate checkouts, so autofixer tests importingexpressmay fail. Keep the resolution check in impact and also install autofixer deps on each server shard that runs those tests.scripts/ci-test-plan.jsSTAGE_DRIFT_RULES: test drift is checked only againstplan.server.files/plan.client.files; a full-suite plan selects tests by mode, so a base-side test change can leave the attestation valid and skip tests the local head never ran. Treat all collected tests as selected in full mode and add coverage.scripts/check-import-case.jsrelativeSpecifiers: dynamic-import/new URLregexes also match string literals (e.g.const x = "import('./foo.js')"), giving false rejections. Tokenize so only executable code matches; test strings and template literals.scripts/pregate-attest.jsplanAttestation(~lines 111, 248): attestation records the posting process's platform/Node instead ofreport.runtime. Read and validate runtime from the receipt; refuse missing/invalid runtime metadata.
Acceptance: each item verified, fixed with a test (or rejected with rationale), pregate green.
- Dominant language
- JavaScript
- Stars
- 38
- Forks
- 32
- Avg merge
- 34m
- Merged PRs (30d)
- 993
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from atomantic/PortOS
-
effort:medium enhancement model:medium plan
Difficulty 4/5 1-2 days Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
bug effort:high model:heavy plan
Difficulty 4/5 3-5 days Newbie friendliness 43/100
atomantic/PortOS#12748 · 1 comment ·
Maintainers usually reply within 1 day
-
Reconcile dead-owner settlement reservations left by crashed publicationsPossibly taken @atomantic claimed this today. Openbug effort:high in-progress model:medium plan
atomantic/PortOS#12740 · 1 assignee ·
Maintainers usually reply within 1 day
-
CI planner runs the full suite for requirements-only Python pin changesPossibly taken @atomantic claimed this today. Opencode-quality effort:low in-progress model:medium plan
atomantic/PortOS#12739 · 1 assignee ·
Maintainers usually reply within 1 day
-
Worktrees made outside the claim prompt never get dependency links, and a cache-only node_modules blocks a later linkPossibly taken @atomantic claimed this today. Openbug effort:medium in-progress model:medium plan
atomantic/PortOS#12734 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in atomantic/PortOS
Similar issues
-
Place search spins forever when nominatim failsPossibly taken @jgt87 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
anvaka/city-roads#213 ·
-
mobile UX
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
jellyfin/jellyfin-web#8685 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
SchemaStore/schemastore#6535 ·
Maintainers usually reply within 1 day
-
enhancement good first issue helia storage tier-1
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
QMeshPy/distributed-quantum#53 ·
Maintainers usually reply within 1 day