UnicodeDecodeError: 'charmap' codec can't decode byte 0x98
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Reproduce the failure by applying 0001-add-file.patch, 0002-some-changes-1.patch, and 0003-some-changes-2.patch, then running git-explode master^ master. Start at git_deps/detector.py in blame_hunk, where subprocess.check_output is called; done means the command handles the reported Russian-character repository without raising UnicodeDecodeError.
Written by the indexing model from the issue text.
Description
I can't run your extension. As I understand it doesn't work with russian letters. I got an error:
$ git-explode master^ master
Traceback (most recent call last):
File "C:/Users/zyrianovdv/AppData/Local/Programs/Python/Python36-32/Scripts/git-explode", line 10, in
sys.exit(run())
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_explode\cli.py", line 68, in run
main(sys.argv[1:])
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_explode\cli.py", line 64, in main
exploder.run()
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_explode\exploder.py", line 39, in run
commits, deps_from, deps_on = self.get_dependencies()
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_explode\exploder.py", line 67, in get_dependencies
detector.find_dependencies(rev)
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_deps\detector.py", line 122, in find_dependencies
self.find_dependencies_with_parent(dependent, parent)
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_deps\detector.py", line 147, in find_dependencies_with_parent
self.blame_hunk(dependent, parent, path, hunk)
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\site-packages\git_deps\detector.py", line 172, in blame_hunk
blame = subprocess.check_output(cmd, universal_newlines=True)
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\subprocess.py", line 336, in check_output
**kwargs).stdout
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\subprocess.py", line 405, in run
stdout, stderr = process.communicate(input, timeout=timeout)
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\subprocess.py", line 830, in communicate
stdout = self.stdout.read()
File "C:\users\zyrianovdv\appdata\local\programs\python\python36-32\lib\encodings\cp1251.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x98 in position 348: character maps to
I created simple repository for reproduction my case. You need apply patches: 0001-add-file.patch, 0002-some-changes-1.patch, 0003-some-changes-2.patch and then git-explode master^ master for reproduction.
patches.zip
- Dominant language
- Python
- Stars
- 60
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aspiers/git-explode
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
aspiers/git-explode#7 ·
-
Ignores --prefixOpen
Difficulty 3/5 1-2 days Newbie friendliness 45/100
aspiers/git-explode#8 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
aspiers/git-explode#6 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
aspiers/git-explode#3 · 3 comments ·
-
Needs decent test coverageMay be free again @aspiers claimed this 3056 days ago, and no pull request is open. Openhelp wanted
aspiers/git-explode#2 · 1 assignee ·
All issues in aspiers/git-explode
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
instance instance add
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
searxng/searx-instances#941 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
FluidNumerics/fluid-walk-blocker#89 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day