Relationships are able to cross tenants with attribute strategy

Open
#192 3 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
elixir, postgresql
Domain
databases

Research direction

Start by running the two cross-tenant relationship tests introduced in commit d8f62872e94bb8e7e115d7e24ec715142ffe4142, then compare the behavior with the change in 0adec1d1634387367bb818e40711e34ceb8cb3e4. Read the Ecto multi-tenancy foreign-key guidance and trace the migration generation involved. Done means primary-key relationships reject cross-tenant inserts at the database level without breaking the case addressed by #144.

Written by the indexing model from the issue text.

Description

bug

Describe the bug
Ash Postgres currently allows relating two resources from two different tenants when using attribute strategy and referencing the primary key of the other resource.

To Reproduce
Here is a commit that adds two tests that manage cross-tenant relationships.

The one that references the primary key is able to add a cross-tenant relationship, the other correctly fails (with a rather cryptic error message though, so I'm not sure if it's actually failing for the right reason).

Expected behavior
I would expect cross-tenant relationship not to be possible

Runtime

  • Elixir version: 1.15.4
  • Erlang version: 26.0.2
  • OS: Debian Testing
  • Ash Postgres version: main

Additional context
The Ecto guide covers this usecase by adding composite foreign keys to disallow inserting cross-tenant associations.

This is what happens for relationships referencing non-primary key attributes, and it was happening also for primary key attributes before 0adec1d1634387367bb818e40711e34ceb8cb3e4.

That commit was made to fix the error shown in #144, but I think that the fix shouldn't have been dropping the composite foreign key, but rather adding the extra [:id, :org_id] unique index in the migration generator (should this be added for all multitenant-attribute resources or just as soon as their primary key gets referenced for the first time?), as is also shown in the Ecto guide.

Of course the cross-tenant relationship is correctly filtered out when reading the resource so it can't be retrieved, but I think it would be better to disallow its creation completely at the database level given there's the possibility to do so.

Dominant language
Elixir
Stars
191
Forks
186
Avg merge
16h 4m
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ash-project/ash_postgres

All issues in ash-project/ash_postgres

Similar issues

More Elixir issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.