Bug: SignInButton render prop usage in "react-tanstack-router" sample missing "onClick={signIn}"
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 92/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- authentication, frontend
Research direction
Open samples/react-tanstack-router/src/pages/Home.tsx and compare the SignInButton render-prop usage with the documented pattern in SignInButton.tsx, especially the signIn handler. Update both custom buttons so their click behavior matches the SDK documentation, then run pnpm dev in samples/react-tanstack-router and verify that Sign In and Get Started initiate sign-in.
Written by the indexing model from the issue text.
Description
Description
The "SignInButton" render prop usage in the "react-tanstack-router" sample app (samples/react-tanstack-router/src/pages/Home.tsx) is missing the onClick={signIn} handler on the custom <button> elements.
This causes the "Sign In" and "Get Started" buttons to be completely non-functional, clicking them does nothing.
The render prop destructures only {isLoading} but ignores the signIn function:
tsx
// Current (broken) — Home.tsx lines 21-23
<SignInButton>
{({isLoading}) => <button disabled={isLoading}>{isLoading ? 'Loading...' : 'Sign In'}</button>}
</SignInButton>
However, the SDK's own JSDoc in SignInButton.tsx (lines 42-48) documents the correct pattern:
tsx
// Expected (from SDK docs)
<SignInButton>
{({signIn, isLoading}) => (
<button onClick={signIn} disabled={isLoading}>
{isLoading ? 'Signing in...' : 'Sign In'}
</button>
)}
</SignInButton>
Steps to Reproduce
- Run the sample app: >> cd samples/react-tanstack-router && pnpm dev
- Open "https://localhost:5173" in a browser
- Click the "Sign In" button, or the "Get Started" button
- Observe: Nothing happens. No redirect, no network request, no error in console
Please select the area the issue is related to
samples, @asgardeo/react
Version
b7fac260ad384964faff25e2cc5cf084dcfe9930
Environment Details (with versions)
-OS: Ubuntu 24.04.4 LTS
- Node.js: v24.11.1
- Browser: Google Chrome 152.0.7977.82
- Vite: 6.4.3
- @tanstack/react-router: 1.154.7
Reporter Checklist
- I have searched the existing issues and this is not a duplicate.
- I have provided all the necessary information.
- I have tested the issue on the latest version of the package.
- Dominant language
- TypeScript
- Stars
- 18
- Forks
- 67
- Avg merge
- 4h 6m
- Merged PRs (30d)
- 13
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from asgardeo/javascript
-
Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
asgardeo/javascript#571 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
asgardeo/javascript#485 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
asgardeo/javascript#527 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 56/100
asgardeo/javascript#522 · 2 comments ·
-
Type/Bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
asgardeo/javascript#519 ·
All issues in asgardeo/javascript
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
danielmiessler/LifeOS#2218 ·