SignUp handleSubmit skipValidation parameter not exposed in TypeScript types
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- react, typescript
- Domain
- authentication, frontend
Research direction
Search the TypeScript definitions for BaseSignUpRenderProps and the equivalent BaseSignIn render-props type. Compare their handleSubmit declarations with the runtime signature described in the issue, update both declarations to expose the optional skipValidation parameter, then run the relevant type checks or tests to confirm consumers can pass the third argument.
Written by the indexing model from the issue text.
Description
Description
The handleSubmit function in the v2 SignUp/SignIn embedded flow components accepts a skipValidation third parameter, but this parameter is not exposed in the TypeScript type definitions. This makes it impossible for consumers using the render props pattern to skip validation for specific actions (e.g., social login triggers that don't need form inputs).
Current Behavior
The runtime function signature supports skipValidation:
// From compiled dist/index.js (~line 11844)
const handleSubmit = async (component, data, skipValidation) => {
if (!skipValidation) {
touchAllFields();
const validation = validateForm();
if (!validation.isValid) {
return;
}
}
// ... proceed with API call
};
But the TypeScript type in BaseSignUpRenderProps only declares:
handleSubmit: (component: any, data?: Record<string, any>) => Promise<void>;
The third parameter is missing from the type, so TypeScript consumers don't know it exists and can't use it without any casting.
Expected Behavior
The type should expose the skipValidation parameter:
handleSubmit: (component: any, data?: Record<string, any>, skipValidation?: boolean) => Promise<void>;
This allows consumers to decide when validation should be skipped based on their own logic. For example, in Thunder's gate, social login trigger buttons skip validation since they don't use form inputs:
onSubmit={(action, inputs) => {
const isTrigger = action.eventType === EmbeddedFlowEventType.Trigger;
void handleSubmit(action, inputs, isTrigger);
}}
Affected Components
- v2 SignUp (
BaseSignUp) —BaseSignUpRenderProps.handleSubmittype definition - v2 SignIn (
BaseSignIn) — equivalent render props type definition
Both have the skipValidation parameter in the runtime implementation but not in the types.
Related
- Thunder issue: https://github.com/asgardeo/thunder/issues/2346
Additional Context
- SDK version:
@asgardeo/react@0.23.1 - The validation-skipping logic should remain a consumer decision, not an SDK-internal assumption — there are valid cases where trigger actions may still need form validation
- Dominant language
- TypeScript
- Stars
- 18
- Forks
- 67
- Avg merge
- 4h 6m
- Merged PRs (30d)
- 13
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from asgardeo/javascript
-
Bug: SignInButton render prop usage in "react-tanstack-router" sample missing "onClick={signIn}" OpenType/Bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
asgardeo/javascript#572 ·
-
Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
asgardeo/javascript#571 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
asgardeo/javascript#527 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 56/100
asgardeo/javascript#522 · 2 comments ·
-
Type/Bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
asgardeo/javascript#519 ·
All issues in asgardeo/javascript
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100