🐛 Bug Report: a non-string header value crashes the whole browser service
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 15/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- bun, playwright, typescript
Research direction
Start with the header schemas and the page.route handlers in src/routes/screenshots.ts and the corresponding reports route. Check how non-string header values are validated and how route callback errors are handled; the report says the failure occurs at screenshots.ts:64. Done means malformed headers return a 400 response, the service stays up, and a regression test covers both endpoints and non-string values.
Written by the indexing model from the issue text.
Description
👟 Reproduction steps
- Start the service (
docker compose up, orbun run src/server.ts). - Send a header whose value is not a string:
curl -X POST localhost:3000/v1/screenshots -H 'content-type: application/json' \ -d '{"url":"https://example.com","headers":{"X-Retry":1}}' - The request gets no response, and
GET /v1/healthnow fails: the server process has exited.
Same for POST /v1/reports, and for true, null, arrays or objects as the value.
👍 Expected behavior
A 400 validation error, like any other malformed field; the service keeps running.
👎 Actual Behavior
The schemas accept any JSON value for headers (z.record(z.string(), z.any())), but Playwright's
route.continue() only takes string values. It throws inside the page.route handler, nothing catches
the rejection, and Bun exits:
error: continue: headers[6].value: expected string, got number
at .../src/routes/screenshots.ts:64:24
Every other capture in flight fails with it.
🎲 Appwrite version
Different version (specify in environment)
💻 Operating system
MacOS
🧱 Your Environment
appwrite/docker-browser main @ 3856d53, run locally with Bun 1.3.2 (the Dockerfile's version) and Google Chrome on macOS arm64.
👀 Have you spent some time to check if this issue has been raised before?
- I checked and didn't find similar issue
🏢 Have you read the Code of Conduct?
- I have read the Code of Conduct
I have a fix with a regression test ready. Could this be assigned to me so I can open a PR?
- Dominant language
- TypeScript
- Stars
- 8
- Forks
- 2
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from appwrite/docker-browser
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
appwrite/docker-browser#20 ·
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
appwrite/docker-browser#15 ·
All issues in appwrite/docker-browser
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
keptinventory/kept#336 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
hemi-earn
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
vetro-protocol/vetro-monorepo#1013 ·
Maintainers usually reply within 1 day