Exact apps in a subdirectory with a non-ASCII folder name never offload
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- cli
Research direction
Read the folder-name check in packages/stim-cli/src/integrations/exact-offload.ts alongside ensureCheckout and exactCheckout in packages/stim-cli/src/offload/worker.ts to confirm when the app is at the repository root. Narrow the check to that case and update the guide line listing this local-build case. Verify that an Exact app in a subdirectory with a non-ASCII folder name offloads normally.
Written by the indexing model from the issue text.
Description
Problem
stim ios builds an Exact app locally instead of offloading it when the app's folder name is not plain ASCII, even when the app sits in a subdirectory of its repository. Only an app at the repository root needs that check.
Evidence
Found in review of #5400: packages/stim-cli/src/integrations/exact-offload.ts (the folder-name check near line 131) applies to every Exact app, while the worker uses the name only for an app at the repository root (ensureCheckout calls exactCheckout only when project === '', packages/stim-cli/src/offload/worker.ts).
Cause
The check predates the change that limited the src -> checkout/<name> link to repository-root apps, and was not narrowed with it.
Fix idea
Apply the name check only when the app is at the repository root, and update the guide line that lists this local-build case. Verify with a subdirectory app whose folder name has a non-ASCII character offloading normally.
- Dominant language
- TypeScript
- Stars
- 100
- Forks
- 8
- Avg merge
- 4h 24m
- Merged PRs (30d)
- 971
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from appandflow/stim
-
area: cli priority: P3 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
appandflow/stim#5640 · 1 comment ·
Maintainers usually reply within 1 day
-
tests: stream tests read an empty pid file as pid 0 and kill(0, 0) succeedsPossibly taken @janicduplessis claimed this today. Openarea: cli priority: P2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
appandflow/stim#5637 · 1 comment ·
Maintainers usually reply within 1 day
-
area: cli priority: P2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
appandflow/stim#5509 ·
Maintainers usually reply within 1 day
-
area: repo priority: P2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
appandflow/stim#5475 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
appandflow/stim#5258 ·
Maintainers usually reply within 1 day
Similar issues
-
Mend: dependency security vulnerability
Difficulty 1/5 1-3 hours Newbie friendliness 65/100
fdm-monster/fdm-monster#5563 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
growilabs/growi#12246 · 3 comments ·
Maintainers usually reply within 1 day
-
🐛 The Rulekeeper - An index run that gives up on the lock ends SucceededPossibly taken @github-actions claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SSWConsulting/SSW.Rules#2809 · 1 comment ·
Maintainers usually reply within 1 day
-
automated-triage type/bug type/ci
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day