JSON Schema: differences with symfony/json-schema
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 22/100
Research direction
The issue bundles four separate schema-generation bugs: DiscriminatorMap handling, empty JSON:API properties serialized as [], enum default normalization, and DateTimeZone description. Start with the api:json-schema:generate and api:openapi:export commands and the code that builds their schemas, and treat each item as its own change. The discriminator item needs a decision on anyOf versus oneOf before anyone writes code, so it is not a good first task.
Written by the indexing model from the issue text.
Description
API Platform version(s) affected
4.4
Description
Comparing api-platform/json-schema with the upcoming symfony/json-schema component (https://github.com/symfony/symfony/pull/66685) shows the following differences.
1. #[DiscriminatorMap] is ignored
When a class uses the serializer's #[DiscriminatorMap], the generated JSON Schema (and the OpenAPI document) describes only the base class. The type property and the properties of the mapped classes are missing. Generated SDKs and MCP tools may misbehave as a result.
Code sample
#[DiscriminatorMap(typeProperty: 'type', mapping: [
'webhook' => WebhookChannelInput::class,
'email' => EmailChannelInput::class,
])]
abstract class NotificationChannelInput
{
}
final class WebhookChannelInput extends NotificationChannelInput
{
public function __construct(
public readonly string $type,
public readonly WebhookConfig $config,
) {
}
}
final class EmailChannelInput extends NotificationChannelInput
{
public function __construct(
public readonly string $type,
public readonly string $address,
) {
}
}
#[ApiResource(operations: [new Post(input: NotificationChannelInput::class)])]
final class ChannelResource
{
}
Current behaviour
bin/console api:json-schema:generate 'App\ApiResource\ChannelResource' --type=input returns ($schema line removed):
{
"$ref": "#/definitions/ChannelResource.NotificationChannelInput",
"definitions": {
"ChannelResource.NotificationChannelInput": {
"type": "object"
}
}
}
The OpenAPI export has the same empty {"type": "object"} for every format.
Behaviour of symfony/json-schema
symfony/json-schema describes the base class as an anyOf of the mapped classes. Each branch requires the type property (unless it is the defaultType), and each mapped class gets its type property as a const. anyOf is used instead of oneOf because some LLM providers reject oneOf. Applied to the sample above, following testDiscriminatorMapBecomesOneOfTheMappedClasses:
{
"$ref": "#/$defs/NotificationChannelInput",
"$defs": {
"NotificationChannelInput": {
"anyOf": [
{"$ref": "#/$defs/WebhookChannelInput", "required": ["type"]},
{"$ref": "#/$defs/EmailChannelInput", "required": ["type"]}
]
},
"WebhookChannelInput": {
"type": "object",
"properties": {
"type": {"type": "string", "const": "webhook"},
"config": {"$ref": "#/$defs/WebhookConfig"}
}
},
"EmailChannelInput": {
"type": "object",
"properties": {
"type": {"type": "string", "const": "email"},
"address": {"type": "string"}
}
}
}
}
2. JSON:API: empty properties is serialized as []
For a class without attributes, the JSON:API schema contains "properties": []. The JSON Schema specification requires properties to be an object, so this is an invalid schema.
Code sample
Same as above: NotificationChannelInput has no properties of its own.
Current behaviour
bin/console api:openapi:export contains, for ChannelResource.NotificationChannelInput.jsonapi:
{
"properties": {
"data": {
"type": "object",
"properties": {
"id": {"type": "string"},
"type": {"type": "string"},
"attributes": {
"type": "object",
"properties": []
}
},
"required": ["type", "id"]
}
}
}
In the API Platform test app, 13 JSON:API schemas have this "attributes": {"properties": []}, among them ExceptionResource.jsonapi and TooManyRequests.jsonapi.
Behaviour of symfony/json-schema
symfony/json-schema has no JSON:API support, but fixed the same bug: getRoot(), getDefinitions() and toArray() return empty schemas as \ArrayObject, so json_encode() prints {} instead of [].
3. Enum defaults are serialized as objects
Only a top-level BackedEnum default is converted to its value. An array of enums, or a UnitEnum default, is serialized as enum objects. JSON Schema recommends that default be valid against its schema; these defaults are not.
Code sample
enum BackedSuit: string
{
case Hearts = 'H';
case Spades = 'S';
}
enum UnitSuit
{
case Hearts;
case Spades;
}
#[ApiResource(operations: [new Get()])]
final class EnumArrayDefault
{
public int $id = 1;
/** @var list<BackedSuit> */
public array $backedSuits = [BackedSuit::Hearts, BackedSuit::Spades];
public UnitSuit $unitSuit = UnitSuit::Spades;
}
Current behaviour
bin/console api:openapi:export contains, for EnumArrayDefault:
"backedSuits": {
"default": [{"name": "Hearts", "value": "H"}, {"name": "Spades", "value": "S"}],
"type": "array",
"items": {"type": "string", "enum": ["H", "S"]}
},
"unitSuit": {
"default": {"name": "Spades"},
"$ref": "#/components/schemas/UnitSuit"
}
Behaviour of symfony/json-schema
symfony/json-schema normalizes defaults recursively: a BackedEnum becomes its value, a UnitEnum its name, and arrays are normalized element by element. The defaults above become ["H", "S"] and "Spades".
4. DateTimeZone is described as an object
Symfony's DateTimeZoneNormalizer serializes a DateTimeZone as a string (e.g. "Europe/Paris"), but the schema describes it as an object built from the getters of the PHP class.
Code sample
#[ApiResource(operations: [new Get()])]
final class Event
{
public int $id = 1;
public ?\DateTimeZone $timezone = null;
}
Current behaviour
bin/console api:openapi:export contains:
"timezone": {
"anyOf": [{"$ref": "#/components/schemas/DateTimeZone"}, {"type": "null"}]
}
"DateTimeZone": {
"type": "object",
"properties": {
"name": {"readOnly": true, "type": "string"},
"transitions": {"readOnly": true, "anyOf": [{"type": "array", "items": {}}, {"type": "boolean", "const": false}]},
"location": {"readOnly": true, "anyOf": [{"type": "array", "items": {}}, {"type": "boolean", "const": false}]}
}
}
The same DateTimeZone definition is repeated for each format (.graphql, .html, .jsonld, .multipart, .xml).
Behaviour of symfony/json-schema
symfony/json-schema describes DateTimeZone as {"type": "string"}.
- Dominant language
- PHP
- Stars
- 2.6k
- Forks
- 989
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 104
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from api-platform/core
-
JSON:API: resource schemas (`*.jsonapi`) have `properties` but no `type: object`Possibly taken @ousamabenyounes claimed this 1 day ago. Open
Difficulty 2/5 Under an hour Newbie friendliness 80/100
api-platform/core#8701 ·
Maintainers usually reply within 1 day
-
JSON:API: `JsonApiCollectionBaseSchemaNoPagination` declares `data` as `type: array` without `items`Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
api-platform/core#8699 ·
Maintainers usually reply within 1 day
-
api:openapi:export --spec-version=3.0.0 outputs `webhooks`, which is invalid in OpenAPI 3.0Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
api-platform/core#8690 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
api-platform/core#8680 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
api-platform/core#8725 ·
Maintainers usually reply within 1 day
All issues in api-platform/core
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
PHP workflow streaming requests buffer the full SSE responsePossibly taken @Winoren claimed this today. Openreview: medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
langgenius/dify#44270 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
bug customer-reported
Difficulty 1/5 Under an hour Newbie friendliness 90/100
MagnaCapax/PMSS#1085 ·
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
nunomaduro/collision#375 ·