NFS StorageProvider renders a missing nfsSubDir as "<no value>"
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
Research direction
The bug is in the Helm template at deploy/helm/templates/storageprovider/nfs.yaml, which always renders subDir from .Parameters.nfsSubDir. Start by reading that template to see how the StorageClass parameters are built, then wrap the subDir line in a conditional so it is emitted only when nfsSubDir is non-empty. Done means a BackupRepo that omits nfsSubDir produces a StorageClass with no subDir parameter, and no <no value> or null appears.
Written by the indexing model from the issue text.
Description
Description
The NFS StorageProvider template always renders subDir from .Parameters.nfsSubDir. The field is optional and has no default. When a BackupRepo omits it, the generated StorageClass parameter is the literal <no value>, and backup files are stored in a directory with that name.
An empty string is not a usable substitute. The same template line renders it as YAML null, which cannot be stored in StorageClass parameters.
Expected behavior
When nfsSubDir is omitted or empty, the StorageClass should not contain subDir. Backups should use the NFS share itself.
Steps to reproduce
Create a BackupRepo with storageProviderRef: nfs and a config that sets nfsServer and nfsShare but not nfsSubDir. Inspect the generated StorageClass parameters.
Environment
- KubeBlocks:
mainand1.0.3-beta.10 - Template:
deploy/helm/templates/storageprovider/nfs.yaml
Additional context
The template should emit subDir only when nfsSubDir is non-empty.
- Dominant language
- Go
- Stars
- 3.1k
- Forks
- 282
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 61
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apecloud/kubeblocks
-
InstanceUpdateStrategy rollingUpdate.replicas doc promises partition-like freeze, but implementation is a per-reconcile batch capMay be free again A pull request for this issue was closed without being merged. OpenStale
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
apecloud/kubeblocks#10656 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apecloud/kubeblocks#11077 ·
Maintainers usually reply within 1 day
-
Support a bounded synchronous switchover deadline beyond 60 secondsMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 42/100
apecloud/kubeblocks#11046 ·
Maintainers usually reply within 1 day
-
[BUG] InstanceSet readiness ignores configured identities and current runtime timingPossibly taken @leon-ape claimed this 12 days ago. Openkind/bug
Difficulty 5/5 Over a week Newbie friendliness 20/100
apecloud/kubeblocks#11030 ·
Maintainers usually reply within 1 day
-
[BUG] Cluster deletion stuck in Deleting because a failed restore Pod still references its PVCPossibly taken @shanshanying claimed this 17 days ago. Openkind/bug
apecloud/kubeblocks#11024 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in apecloud/kubeblocks
Similar issues
-
agent-butler-finding chore
Difficulty 1/5 Under an hour Newbie friendliness 88/100
jordansmall/spindrift#6695 ·
Maintainers usually reply within 1 day
-
skills-init: commit-SHA skill refs never start (git checkout -- <sha> reads the SHA as a pathspec)Open
Difficulty 1/5 Under an hour Newbie friendliness 84/100
kagent-dev/kagent#3571 ·
Maintainers usually reply within 1 day
-
book-layout.spec fails when the similar-books rail holds other projects' booksPossibly taken @praetorianer777 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
praetorianer777/GoTome#373 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
/shutdown/ready can fail to return an HTTP response when readiness takes longer than the server write timeoutPossibly taken @floriankoch claimed this today. Opentriage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
envoyproxy/gateway#10562 ·
Maintainers usually reply within 1 day