check why this does not work because of the List<V> generic type

Open
#375 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
java

Research direction

Start with wayang-ml4all/src/main/java/org/apache/wayang/ml4all/abstraction/plan/wrappers/AssignWrapper.java, especially its List declaration, Update<R, ?> field, constructor, and commented open method. Trace the related LogicalOperatorWrapperWithContext and Update types to determine why the generic List type fails. Done means the issue is understood and the project builds with a correct, type-safe AssignWrapper implementation.

Written by the indexing model from the issue text.

Description

todo

check why this does not work because of the List generic type

public void open(ExecutionContext executionContext) {

context = executionContext.getBroadcast("context").iterator().next();

https://github.com/apache/incubator-wayang/blob/d75a5723989928ac2e633d76bf665b2a5cb3eaf1/wayang-ml4all/src/main/java/org/apache/wayang/ml4all/abstraction/plan/wrappers/AssignWrapper.java#L26


/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.wayang.ml4all.abstraction.plan.wrappers;

import org.apache.wayang.ml4all.abstraction.api.Update;
import org.apache.wayang.ml4all.abstraction.plan.ML4allGlobalVars;

import java.util.List;

public class AssignWrapper<R> extends LogicalOperatorWrapperWithContext<ML4allGlobalVars, List<R>> { //TODO:check why this does not work because of the List<V> generic type

    Update<R,?> logOp;

    public AssignWrapper(Update logOp) {
        this.logOp = logOp;
    }

    @Override
    public ML4allGlobalVars apply(List<R> o) {
        ML4allGlobalVars newContext = context.clone();
        return this.logOp.assign(o, newContext);
    }

    @Override
    public void initialise() {

    }

//    @Override
//    public void open(ExecutionContext executionContext) {
//        context = executionContext.<ML4allGlobalVars>getBroadcast("context").iterator().next();
//
//    }
}

c3d0a623a7d8e7bac13e2adf6316762638dd2b33

Dominant language
Java
Stars
284
Forks
147
Avg merge
2d 13h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/wayang

All issues in apache/wayang

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.