investigate why sample needs an extra implicit

Open
  • Is something wrong?
#49 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
grpc, scala
Domain
api

Research direction

Start with the linked incubator-pekko-samples pull request diff and reproduce the sample compilation using sbt-pekko-grpc 2.1.6, comparing it with version 0.8.4. Determine whether the additional ActorSystem implicit is required, then establish whether the sample or its documentation needs updating.

Written by the indexing model from the issue text.

Description

The sample was using a pretty old version of sbt-akka-grpc (0.8.4) and sbt-pekko-grpc is the equivalent of sbt-akka-grpc 2.1.6.

https://github.com/apache/incubator-pekko-samples/pull/12/files#diff-fe64fb9ec6ea3e1173f14f9d82f39712eaa40f3d0dc67d9cc54ec5cf91490465

Note that https://github.com/apache/incubator-pekko-samples/pull/12/files#diff-fe64fb9ec6ea3e1173f14f9d82f39712eaa40f3d0dc67d9cc54ec5cf91490465 needs ActorSystem as an implicit val to compile now.

Or we might need to update the docs to say why this is needed.

Dominant language
Scala
Stars
56
Forks
31
Avg merge
1d 13h
Merged PRs (30d)
20

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/pekko-grpc

All issues in apache/pekko-grpc

Similar issues

More Scala issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.