Avoid deprecated nameResolverFactory
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
Research direction
Start with runtime/src/main/scala/org/apache/pekko/grpc/internal/NettyClientUtils.scala, especially the name-resolver code around lines 49–64. Compare it with the linked grpc-java NameResolveClient example and the proposed NameResolverRegistry registration. Done means the deprecated nameResolverFactory usage is replaced without changing the resolver settings passed to PekkoDiscoveryNameResolverProvider.
Written by the indexing model from the issue text.
Description
I was reading the code for name solver and found a todo item, hoping to resolve it.
motivation
same issue in akka-grpc https://github.com/akka/akka-grpc/issues/1092
code in pekko org.apache.pekko.grpc.internal.NettyClientUtils
changes
according to grpc-java
we just need
NameResolverRegistry.getDefaultRegistry.register(
new PekkoDiscoveryNameResolverProvider(
settings.serviceDiscovery,
settings.defaultPort,
settings.serviceName,
settings.servicePortName,
settings.serviceProtocol,
settings.resolveTimeout))
- Dominant language
- Scala
- Stars
- 55
- Forks
- 30
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/pekko-grpc
-
Difficulty 4/5 3-5 days Newbie friendliness 43/100
apache/pekko-grpc#933 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
apache/pekko-grpc#932 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
apache/pekko-grpc#931 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
apache/pekko-grpc#930 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 46/100
apache/pekko-grpc#929 ·
Maintainers usually reply within 1 day
All issues in apache/pekko-grpc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
lichess-org/lila#22324 · 1 comment ·
Maintainers usually reply within 1 day
-
area:ci enhancement priority:low requires-triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
apache/datafusion-comet#7319 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day