REST Catalog alterTable silently reports success when the server returns a non-table/column 404
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start at the REST Catalog alterTable entry point and inspect its NoSuchResourceException handling for 404 resource types beyond TABLE and COLUMN. Compare the analogous createBranch default branch mentioned in the issue. Done means an unmapped 404, such as a DATABASE not-found, no longer returns silent success; verify the concurrent-database-drop reproduction reports an error.
Written by the indexing model from the issue text.
Description
Search before asking
- I searched in the issues and found no similar issues.
Paimon version
master (1.5-SNAPSHOT)
Compute Engine
Any engine using the REST Catalog.
Minimal reproduce step
- Use a REST catalog.
- Call
alterTable(identifier, changes, ignoreIfNotExists = false)in a situation where the REST server answers with a 404 whose resource type is neitherTABLEnorCOLUMN, for example aDATABASEnot-found because the table's database was concurrently dropped.
What doesn't meet your expectations?
alterTable returns normally and reports success even though the ALTER did not apply. The NoSuchResourceException handler only covers the TABLE and COLUMN resource types; for any other type it falls through the if/else-if chain and the method returns without error, so a failed alter is silently swallowed.
Anything else?
The sibling createBranch already rethrows in the analogous default branch of the same kind of dispatch. alterTable was the only one that let an unmapped 404 fall through to silent success.
Are you willing to submit a PR?
- I'm willing to submit a PR!
- Dominant language
- Java
- Stars
- 3.4k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 490
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/paimon
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
feature triaged
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Graylog2/graylog2-server#27549 ·
Maintainers usually reply within 1 day
-
component/zeebe kind/bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
UniversalMediaServer/UniversalMediaServer#6356 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
googleapis/google-cloud-java#14533 ·
Maintainers usually reply within 1 day