Downstream dialect allowlists don't recognize OSSIE_SQL_2026

Open
#32 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Read the five affected locations listed in the issue, starting with the allowlists and fallback chains in the Orionbelt, Snowflake, Databricks, and Wisdom converters, then review validation/validate.py's DIALECT_MAP and SKIP_SQL_VALIDATION. Add regression tests for fields or metrics expressed only in OSSIE_SQL_2026 in each affected component. Done means those values are retained or handled without misleading warnings, and validation maps the dialect explicitly.

Written by the indexing model from the issue text.

Description

needs-triage

Background

apache/ossie#439 added OSSIE_SQL_2026 as a dialect in the core spec, and apache/ossie#440 added the matching value to the Python OssieDialect enum. Documents using OSSIE_SQL_2026 now pass model validation, but several downstream components hard-code dialect allowlists that predate this dialect and don't recognize it. As a result, fields/metrics expressed only in OSSIE_SQL_2026 are silently dropped or produce misleading warnings, even though the dialect is ANSI-SQL-compatible.

Affected locations

  • converters/orionbelt/src/ossie_orionbelt/_common.py:41 — _SQL_PARSEABLE_DIALECTS tuple omits OSSIE_SQL_2026, so _select_sql_expression() drops such metrics from OBML export with a "no SQL-parseable dialect" warning.
  • converters/snowflake/src/ossie_snowflake/converter.py:372 — _extract_expression() only recognizes SNOWFLAKE/ANSI_SQL, so matching fields/metrics are skipped from Snowflake export with a misleading warning.
  • converters/databricks/src/ossie_databricks/_common.py:231 — pick_expression() only falls back through DATABRICKS/ANSI_SQL, returning None and causing the field/metric to be dropped from Databricks Metric View output.
  • converters/wisdom/src/ossie_wisdom/ossie_to_wisdom.py:148 — _infer_dataset_dialect() / _pick_expression() never check OSSIE_SQL_2026, producing a spurious MISSING_DIALECT_EXPRESSION issue even though a fallback expression is still used.
  • validation/validate.py:67 — DIALECT_MAP / SKIP_SQL_VALIDATION omit OSSIE_SQL_2026; it currently validates correctly only by accident, because dict.get()'s default happens to match the same None sentinel used for ANSI_SQL. This should be made an explicit mapping rather than relying on that coincidence.

Suggested fix

Treat OSSIE_SQL_2026 as ANSI-SQL-compatible in each of the allowlists/fallback chains above (mirroring how ANSI_SQL is handled), and add regression tests per converter covering a field/metric expressed only in OSSIE_SQL_2026.

Related

Follow-up from review of apache/ossie#440.

Dominant language
Python
Stars
45
Forks
53
Avg merge
3d 23h
Merged PRs (30d)
100

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/ossie-converters

All issues in apache/ossie-converters

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.