[MPH-205] Handling empty elements

Open
#329 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
build-system

Research direction

Start at the effective-settings goal and reproduce the failure with a settings.xml containing empty elements such as ; the issue also raises whether toolchains.xml behaves similarly. Compare the behavior across the mentioned Maven versions, and consider the case complete when effective-settings handles empty configuration without the reported null-configuration failure.

Written by the indexing model from the issue text.

Description

bug priority:major

Delany opened MPH-205 and commented

When i needed a settings.xml file in the past I would copy the code from
https://maven.apache.org/settings.html
https://maven.apache.org/ref/4.0.0-alpha-5/maven-settings/settings.html
 
and replace the self-closing tag of whichever section I needed - typically servers, mirrors and profiles. The other tags would remain, like "<localRepository/>"
 
With Maven 3.9.0 the empty/self-closing tag was ignored.
 
In Maven 4.0.0-alpha-1 the value is removed/replaced, resulting in the local repository directory set to ${pwd}.
This is the case for settings.xml (what about toolchains.xml?) but not pom.xml
 
With Maven 4.0.0-alpha-5, and I guess https://issues.apache.org/jira/browse/MNG-7678
the behaviour has changed back to that of Maven 3 - an empty tag is simply ignored, it doesn't override.
But while the build is successful, mvn help:effective-settings now fails with

Execution default-cli of goal org.apache.maven.plugins:maven-help-plugin:3.4.0:effective-settings failed: Cannot invoke "org.codehaus.plexus.util.xml.Xpp3Dom.getDom()" because "configuration" is null

Affects: 3.4.0

Dominant language
Java
Stars
29
Forks
42
Avg merge
23h 15m
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-help-plugin

All issues in apache/maven-help-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.