EffectiveSettingsMojo.copySettings() does not deep-copy profiles

Open Beginner friendly
#388 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java
Domain
build-system, tooling

Research direction

Start in src/main/java/org/apache/maven/plugins/help/EffectiveSettingsMojo.java:156-198 and inspect how SettingsUtils.copySettings() handles profiles compared with servers and proxies. Verify that the copied settings no longer shares profiles or their sensitive properties with the original; done means profile data remains isolated after the original settings object is queried or changed.

Written by the indexing model from the issue text.

Description

bug

In src/main/java/org/apache/maven/plugins/help/EffectiveSettingsMojo.java:156-198:

Only servers and proxies are manually deep-copied. The profiles list is shared with the original via the shallow SettingsUtils.copySettings(). Profiles can contain sensitive data (passwords in properties) that would be exposed if the original settings object is later queried expecting the copy to be isolated.

Dominant language
Java
Stars
29
Forks
42
Avg merge
23h 15m
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-help-plugin

All issues in apache/maven-help-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.