requireSameVersions drops members from its message when sources share a version
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1075 by @arturobernalg — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Read RequireSameVersions.java:74-93 and trace how execute combines dependencies, build plugins, and report plugins by version. Reproduce the example with two artifacts at version 1.0 and another at 2.0, then check the relevant rule tests for the failure message. Done means the 1.0 message includes members from both sources while version detection still works.
Written by the indexing model from the issue text.
Description
RequireSameVersions.execute builds one Map<String, List<String>> keyed by version and fills it with three putAll calls, for dependencies, build plugins and report plugins (RequireSameVersions.java:74-93). When two of those sources have an artifact at the same version, the later putAll replaces the earlier list for that version, so the failure message no longer lists the earlier members. Detection is unaffected (versionMembers.size() > 1 counts the same keys), only the message is incomplete.
Example: a dependency foo:a:1.0 and a build plugin foo:b:1.0 matching the same pattern, plus a dependency at 2.0: the 1.0 line names only the plugin.
- Dominant language
- Java
- Stars
- 162
- Forks
- 190
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 20
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/maven-enforcer
-
RequireUpperBoundDeps does not support includes with only groupIdPossibly taken @waterWang claimed this 105 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/maven-enforcer#998 ·
Maintainers usually reply within 1 day
-
Document `bannedDependencies` behavior change in 3.7.0 and provide an opt-out for optional dependenciesPossibly taken @slawekjaranowski claimed this 1 day ago. Openbug
apache/maven-enforcer#1077 · 1 comment · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
apache/maven-enforcer#1038 · 1 comment ·
Maintainers usually reply within 1 day
-
New rule: banSplitPackages — detect packages split across modules and artifactsMay be free again @ascheman claimed this 110 days ago, and no pull request is open. Openenhancement
apache/maven-enforcer#997 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
New rules: enforce Java Module System descriptor policyMay be free again @ascheman claimed this 116 days ago, and no pull request is open. Openenhancement
apache/maven-enforcer#995 · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
All issues in apache/maven-enforcer
Similar issues
-
pdfium-drift
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Stirling-Tools/JPDFium#240 ·
Maintainers usually reply within 1 day
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Vakore/ZappierGames#285 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
objectionary/jeo-maven-plugin#2008 ·
Maintainers usually reply within 1 day