[MCHECKSTYLE-376] The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
Maintainers usually reply within 1 day
@eolivelli is already working on this.
Since Jun 13, 2025.
Assessment
This issue has not been assessed yet.
Description
Tibor Digana opened MCHECKSTYLE-376 and commented
Afects version 3.1.0 during the release vote.
It looks like the library expects system based EOL character.
The checkstyle reports the issue in two files in https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
I doubt it is a problem with these two files, nothing but the library itself.
No idea why other ITs do not fail on Windows too.
mvn -nsu checkstyle:check
[INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @ mcheckstyle-54 ---
[INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml ruleset.
[ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] (misc) NewlineAtEndOfFile: File does not end with a newline.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.450 s
[INFO] Finished at: 2019-05-13T23:42:55+02:00
[INFO] Final Memory: 12M/193M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Attachments:
- linux.zip (1.50 kB)
- windows.zip (1.54 kB)
Remote Links:
0 votes, 6 watchers
- Dominant language
- Java
- Stars
- 97
- Forks
- 68
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/maven-checkstyle-plugin
-
maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#718 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 38/100
apache/maven-checkstyle-plugin#675 ·
Maintainers usually reply within 1 day
-
Update dependencies.May be free again A pull request for this issue was closed without being merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#664 ·
Maintainers usually reply within 1 day
-
DefaultCheckstyleExecutor should be a failure, not an errorPossibly taken @efegokdemir claimed this 24 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
apache/maven-checkstyle-plugin#656 · 1 comment ·
Maintainers usually reply within 1 day
-
Add ability to print warnings when `failOnViolation: true` and `violationSeverity: error`Possibly taken @efegokdemir claimed this 22 days ago. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 50/100
apache/maven-checkstyle-plugin#648 · 5 comments ·
Maintainers usually reply within 1 day
All issues in apache/maven-checkstyle-plugin
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
apache/rocketmq-dashboard#6896 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
Unrecognized database schema version is treated as a pre-2.0 databasePossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OpenIntegrationEngine/engine#496 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
SasanLabs/VulnerableApp#836 ·
Maintainers usually reply within 1 day