[MCHECKSTYLE-355] Allow checkstyleRules next to configLocation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- build-system
Research direction
Start by reproducing the reported Maven configuration with configLocation and checkstyleRules, then trace how the plugin handles these two settings. Identify the existing validation or configuration-merging entry point; done means inline rules override the corresponding configLocation rule without the current failure, with coverage for the LineLength example.
Written by the indexing model from the issue text.
Description
HerrDerb opened MCHECKSTYLE-355 and commented
Summary
Allow to define a configLocation and checkstyleRules resulting in inline checkstyle rules overriding configLocation checks. This would allow a dynamic checkstyle rule configuration.
Current behaviour
Currently when running the plugin with the following configuration
<configuration>
<configLocation>google_checks.xml</configLocation>
<checkstyleRules>
<module name="LineLength">
<property name="max" value="120"/>
</module>
</checkstyleRules>
</configuration>
it fails and returns
Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default) on project comlab-pom: If you use inline configuration for rules, don't specify a configLocation
Desired behaviour
The google check LineLenth is overriden by the inline check, defining a valid line length of 120 instead of 80.
No further details from MCHECKSTYLE-355
- Dominant language
- Java
- Stars
- 98
- Forks
- 69
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/maven-checkstyle-plugin
-
maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#718 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 38/100
apache/maven-checkstyle-plugin#675 ·
Maintainers usually reply within 1 day
-
Update dependencies.May be free again A pull request for this issue was closed without being merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#664 ·
Maintainers usually reply within 1 day
-
DefaultCheckstyleExecutor should be a failure, not an errorPossibly taken @efegokdemir claimed this 33 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
apache/maven-checkstyle-plugin#656 · 1 comment ·
Maintainers usually reply within 1 day
-
Add ability to print warnings when `failOnViolation: true` and `violationSeverity: error`Possibly taken @efegokdemir claimed this 31 days ago. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 50/100
apache/maven-checkstyle-plugin#648 · 5 comments ·
Maintainers usually reply within 1 day
All issues in apache/maven-checkstyle-plugin
Similar issues
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
protobuf
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
FasterXML/jackson-dataformats-binary#874 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
HexaHexes/infinite-dungeon-spawn-safety#17 ·
Maintainers usually reply within 1 day