S3 remote-signer Request header case duplicated

Open Beginner friendly
#2,422 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
aws, python
Domain
cloud

Research direction

Start in pyiceberg/io/fsspec.py at lines 106-121 and trace how remote-signer response headers are copied into the request. Verify the change preserves the returned value without creating duplicate X-Amz-Content-SHA256 headers, then validate the resulting request and signing behavior with the relevant tests.

Written by the indexing model from the issue text.

Description

Apache Iceberg version

0.9.1 (latest release)

Please describe the bug 🐞

request header X-Amz-Content-SHA256 passed to the catalog service is STREAMING-UNSIGNED-PAYLOAD-TRAILER, and the header X-Amz-Content-SHA256 returned by the catalog service is UNSIGNED-PAYLOAD

but the code logic will add both headers to the request (two X-Amz-Content-SHA256 header).

At this time, there is a possibility that the signature will not be passed (because the file storage service get STREAMING-UNSIGNED-PAYLOAD-TRAILER header, bug signed with UNSIGNED-PAYLOAD)

https://github.com/apache/iceberg-python/blob/52d810efb62e39ec6d8d6a2f4cd2cad8165e2d2c/pyiceberg/io/fsspec.py#L106-L121

line120-121 change to this can can solve the problem

    headers = HTTPHeaders()
    for key, value in response_json["headers"].items():
        headers.add_header(key, ", ".join(value))

    request.headers = headers
Willingness to contribute
  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
Dominant language
Python
Stars
1.1k
Forks
589
Avg merge
2d 4h
Merged PRs (30d)
72

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/iceberg-python

All issues in apache/iceberg-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.