[VL] Remove the unused veloxToArrow metric
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 58/100
Research direction
Trace veloxToArrow through ColumnarBatch, ResultIterator, Runtime::getMetrics, the JNI Metrics constructor, MetricsUtil.updateTransformerMetricsInternal, and JoinMetricsUpdater.updateJoinMetrics in the Velox and Bolt backends. Start by checking the JVM side after #3854 and the native metric’s production in VeloxColumnarBatch::ensureFlattened; remove its carrying code and the unused parameter. Done when no path sends or consumes the metric and the uninitialized exportNanos_ value is no longer sent.
Written by the indexing model from the issue text.
Description
The native veloxToArrow metric, the time VeloxColumnarBatch::ensureFlattened spends flattening a batch before it is exported, is sent to the JVM in Metrics.SingleMetric. Nothing on the JVM side has read it since #3854. The value is still carried through ColumnarBatch, ResultIterator, Runtime::getMetrics, the JNI Metrics constructor, MetricsUtil.updateTransformerMetricsInternal and JoinMetricsUpdater.updateJoinMetrics, which takes it as a parameter and ignores it. ResultIterator::exportNanos_ is also never initialized, so fetching metrics from an iterator that never produced a batch sends an indeterminate value to the JVM.
The metric and the code that carries it can be removed from the Velox and Bolt backends.
This issue was written with the assistance of AI (Claude Opus).
- Dominant language
- Scala
- Stars
- 1.6k
- Forks
- 679
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 84
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/gluten
-
[CORE] Selecting a cost model the backend has no coster for fails with ClassNotFoundExceptionPossibly taken @LuciferYang claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 3 days
-
bug unit testing velox backend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/gluten#13463 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 3 days
-
[VL] madvise(WILLNEED) call fails in MmapFileStream because of wrong calculation of fetching lengthMay be free again A pull request for this issue was closed without being merged. Openbug triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 3 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rchillyard/TableParser#206 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
? - Needs Triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
NVIDIA/cudf-spark#17063 ·
Maintainers usually reply within 2 days
-
bug 🐞 User issue 🚨
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
valkey-io/valkey-glide#7813 · 2 comments ·
Maintainers usually reply within 1 day