Two dynamic off-heap sizing bugs: MinHeapFreeRatio not restored, availability metric reads the wrong pools

Open
#13,093 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
scala

Research direction

Start with DynamicOffHeapSizingMemoryTarget.shrinkOnHeapMemory and inspect its finally block, then trace SparkMemoryUtil.getCurrentAvailableOffHeapMemory and the GlobalOffHeapMemoryTarget callers. Verify the dynamic sizing path restores both heap ratios and reports the pools used for global reservations, including the Velox columnar shuffle writer's memLimit behavior.

Written by the indexing model from the issue text.

Description

Both bugs are in the dynamic off-heap sizing path, gated by spark.gluten.memory.dynamic.offHeap.sizing.enabled (experimental, off by default), so they only affect deployments that opt into that flag.

1. MinHeapFreeRatio is never restored after a heap shrink. DynamicOffHeapSizingMemoryTarget.shrinkOnHeapMemory lowers both MinHeapFreeRatio and MaxHeapFreeRatio so the JVM releases committed heap, but the finally block restores only MaxHeapFreeRatio. After the first shrink the executor keeps MinHeapFreeRatio=5 for the rest of its life. The heap then stays tighter and the JVM GCs more often, well after the off-heap pressure that triggered the shrink has passed.

2. The available off-heap metric reads the wrong pools under dynamic sizing. SparkMemoryUtil.getCurrentAvailableOffHeapMemory sums the off-heap storage and execution pools. Under dynamic sizing, Gluten charges its global reservations to the on-heap pools (GlobalOffHeapMemoryTarget acquires with ON_HEAP) and the driver plugin forces spark.memory.offHeap.size=0, so the off-heap pools are empty and the method returns 0. The Velox columnar shuffle writer uses that value as its memLimit, so it drops to the minimum buffer size.

Dominant language
Scala
Stars
1.6k
Forks
679
Avg merge
4d 16h
Merged PRs (30d)
84

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/gluten

All issues in apache/gluten

Similar issues

More Scala issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.